Skip to content

Generic sort and filter transforms. #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Generic sort and filter transforms. #205

merged 3 commits into from
Mar 9, 2021

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Mar 9, 2021

Supersedes #203.
Fixes #180.
Fixes #179.
Fixes #138.

Because this happens at the maybeTransform layer, all the built-in transforms such as stack now support the sort and filter options, too.

@mbostock mbostock requested a review from Fil March 9, 2021 17:56
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is great!

Very nice that we we can filter and sort. One thing that might need an error message is if sort or filter are ignored because of a (more explicit, more generic) transform.

@mbostock mbostock merged commit 38c66a6 into main Mar 9, 2021
@mbostock mbostock deleted the mbostock/filter branch March 9, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants