Skip to content

use the context’s document to create the input Event #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

use the context’s document to create the input Event #2169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123509a
use the context’s document to create the input Event
Fil Sep 11, 2024
e5d7d97
Update src/plot.js
Fil Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ export function plot(options = {}) {
context.dispatchValue = (value) => {
if (figure.value === value) return;
figure.value = value;
figure.dispatchEvent(new Event("input", {bubbles: true}));
const Event = context.document.defaultView?.Event;
if (Event) figure.dispatchEvent(new Event("input", {bubbles: true}));
};

// Reinitialize; for deriving channels dependent on other channels.
Expand Down
8 changes: 8 additions & 0 deletions test/event-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import * as Plot from "@observablehq/plot";
import * as assert from "assert";
import {JSDOM} from "jsdom";

it("Plot uses the context’s event", () => {
Plot.lineY([1, 2, 3], {tip: true}).plot({document: new JSDOM("").window.document});
assert.ok(true);
});