-
Notifications
You must be signed in to change notification settings - Fork 185
add a {line: true} option to axes #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this makes me want to have a |
This seems like a good option to have, but I’m struggling with the name “support”—that doesn’t resonate with me. D3 calls this the “domain path”. Maybe axisLine would be okay? Should we allow you to style this line separately from the grid? It does seem related to the “frame” concept, too, so maybe frame would be okay as an option. |
Is "support" a frenchism? Maybe a better translation for what I had in mind is “bearing” or “beam”. Anyway, in this PR the axis line would be added (or "not removed" :)) on the materialized axes, not on all facets. By contrast, Plot.ruleX([0]) and Plot.frame are present on all facets (more precisely "active" facets #332). |
Needs a better name than “support” but otherwise I’m onboard with the option. |
axisLine is fine, I think? |
handy for materializing the vertical axis of a bar chart with an ordinal x note that in the case of a continuous *X*, tickX([*extent min*]) is often preferable, since it creates the support line for all x/y facets
What about simply the name “line”? That seems to match the name “grid” pretty well, and I can’t think of any obvious ambiguity with the shorter name. |
handy for materializing the vertical axis of a bar chart with an ordinal x
note that in the case of a continuous X, tickX([extent min]) is often preferable, since it creates the support line for all x/y facets
see https://observablehq.com/@fil/axis-support-406
suggested by @EE2dev