imageFilter (support for the CSS filter attribute) #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Aug 11, 2021
There was a problem hiding this comment.
I’m going to punt on this. I’m unsure about the name “colorFilter”. It’s unfortunate that we can’t use filter because it conflicts with the basic transform. We could, possibly, interpret the filter as CSS filter if it’s a valid CSS filter function string, similar to how we validate colors. But that’s a little fancy…
Draft
|
I think we should do this, but we should call it imageFilter instead of colorFilter. |
Fil
changed the title
|
rebased as imageFilter. |
mbostock
reviewed
May 8, 2023
mbostock
approved these changes
May 8, 2023
57 tasks
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with dark mode (#408)