Expose Plot.channel and Plot.transform #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
force-pushed
the
fil/expose-transform-column
branch
from
0153e5d to
38c2452
Compare
|
Rewritten; this time I've left out the renaming of maybeLazyChannel into column, and basic into transform, since it only creates merge conflicts. But when (if) we merge, it would be good to rename these functions internally. |
Closed
|
Looks like the documentation needs updating here, since Plot.transform now takes (options, transform) rather than (...transforms)? |
|
Also, do we want to expose maybeLazyChannel here, or lazyChannel? My inclination is that I’d prefer Plot.column to be an alias for the latter, so that a setter function is always returned (even if there is no source input). |
Fil
force-pushed
the
fil/expose-transform-column
branch
from
38c2452 to
8dab9dc
Compare
|
rebased with fixes to the documentation and adoption of lazyChannel instead of maybeLazyChannel. |
mbostock
approved these changes
Mar 2, 2022
mbostock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helpers to create custom transforms (#170)
An example uses Plot.transform to create a uniform sample transform (diamond-carat-sampling)
An example of Plot.column is available at https://observablehq.com/@fil/plot-splom