create a non-empty bar if the domain is collapsed #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
fil/zero-width-bins
branch
from
8fe5a11 to
74234af
Compare
mbostock
requested changes
Jul 31, 2021
There was a problem hiding this comment.
I would like to fix this issue, but I think we’ll need a different fix. One issue here is that if you have a log x-scale (which admittedly is a little weird when binning, but is theoretically valid), then adding the fixed offset to x0 = x1 could mean that your x-domain will cross zero. I think we may want to fix this at the rendering layer (i.e., marks) rather than by changing the semantics of the data transform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g. binning of a one-element data)
degenerate case example given by @severo in #417