Skip to content

Plot.groupX({filter: () => true}) #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Plot.groupX({filter: () => true}) #500

wants to merge 6 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Aug 13, 2021

follow-up on #499: using Plot.groupX({filter: () => true}…) creates empty points where there is no data

todo:

  • the code is a bit ugly
  • for feature parity with binX, the filter should receive the data, not just the index; and maybe the group too?
  • use InternSet
  • motivate with a meaningful example
  • use filter: "all" as a shorthand for {filter: () => true}?
  • optimize: we can probably sort once instead of sorting each group
  • optimize: probably no need to loop through X × Y if there is no filter
  • can probably do without sorting (ref. sort groups #414)

@mbostock
Copy link
Member

Yeah, nice, this is what I was imagining with the Cartesian product idea. Not sure how urgently we should tackle this but I like the direction. 🙂

Base automatically changed from mbostock/fix-empty-group to main August 13, 2021 17:08
@Fil
Copy link
Contributor Author

Fil commented Feb 6, 2023

obsolete since v0.2!

@Fil Fil closed this Feb 6, 2023
@Fil Fil deleted the fil/fill-groups branch February 6, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants