Skip to content

Dodge: use the mark's this.r if present #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Dodge: use the mark's this.r if present #711

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf02423
Use the mark's this.r if present, otherwise default to reading the op…
Fil Jan 27, 2022
465fa1f
Update src/layouts/dodge.js
Fil Jan 27, 2022
beec1f0
superfluous import
Fil Jan 27, 2022
586175d
Update src/layouts/dodge.js
Fil Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/layouts/dodge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ export function dodgeY(dodgeOptions = {}, options = {}) {
}

function dodge(y, x, anchor, padding, options) {
const [, r] = maybeNumberChannel(options.r, 3);
return layout(options, (I, scales, {[x]: X, r: R}, dimensions) => {
const [, r0] = maybeNumberChannel(options.r, 3);
return layout(options, function(I, scales, {[x]: X, r: R}, dimensions) {
const r = this.r == null ? r0 : this.r;
if (X == null) throw new Error(`missing channel: ${x}`);
let [ky, ty] = anchor(dimensions);
const compare = ky ? compareAscending : compareSymmetric;
Expand Down
Loading