Skip to content

Conversation

@mbostock
Copy link
Member

@mbostock mbostock commented Mar 25, 2022

E.g. promotes x to x1 and x2 if the latter two are not specified.

I’m not sure why the aaplMonthly snapshot changed. 🤔 Update: Fil figured it out.

@mbostock mbostock requested a review from Fil March 25, 2022 17:08
@Fil
Copy link
Contributor

Fil commented Mar 26, 2022

The aaplMonthly snapshot changed because we're now calling maybeInset on the Y dimension, whereas in main we are returning earlier at

if (value == null || interval == null) return options;

In the cli tests the insets we get are [1, 0], and in the browser, on a retina screen, [0.5, 0.5].

@mbostock
Copy link
Member Author

The aaplMonthly snapshot changed because we're now calling maybeInset on the Y dimension

Ah, thanks for figuring that out! I think we can avoid that when the interval is null.

@mbostock mbostock force-pushed the mbostock/trivial-interval branch from 5ffdfc5 to 16db0d4 Compare March 26, 2022 17:55
@mbostock
Copy link
Member Author

How’s this, @Fil?

@mbostock mbostock merged commit dc083a3 into main Mar 26, 2022
@mbostock mbostock deleted the mbostock/trivial-interval branch March 26, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants