Fix Plot.hexbin default reducer, and simplify #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
fil/reinitialize
branch
from
3820065 to
388c3d1
Compare
|
I’m still reviewing the implementation of the hexbin transform in the other branch, so I’m just going to blindly merge this now so I don’t have to review it twice. My intuition is there are things I want to change here. |
mbostock
reviewed
May 27, 2022
mbostock
added a commit
that referenced
this pull request
May 28, 2022
* mark initializers scale hex radius so that when hexagons touch, circles also touch without overlapping (#803) (supersedes #795) simpler hexagon hexgrid fix for unscaled channels reorder hexbin fix #806; handle missing hint infer channel scales pass data to initializer offset hexagonal grid slightly simpler without destructuring reinitialize (#823) * document layouts (as "scale-aware transforms") * document binWidth * document the initialize option after 42ac4f0 * sort hex bins by radius (descending) group by z inline hexbin binWidth is the distance between two centers (rebased on mbostock/reinitialize) * dodge rebased on mbostock/reinitialize * compose intializers * use composeInitialize to make dodge composable * add new channels as you compose initializers * darker transform, to demonstrate composition with dodgeY (added as an example, but we could promote it to a transform) * a more generic "remap" * jiggle layout (using the same remap intializer as in the darkerDodge plot) composeInitialize * update dependencies * Update README * Update README * tweak error message * Fix Plot.hexbin default reducer, and simplify (#884) * sort tests * revert inlined hexbin implementation * simpler z * simpler scale application * re-inline d3-hexbin * use descendingDefined to sort * coerce X and Y to numbers * populate radius hint * fix hexbin z; implicit group on symbol * update tests * expose initialize; rewrite remap * tweak tests * tweak tests * tweak tests * tweak tests * tweak tests * tweak tests * tweak tests * tweak tests * fix scale association, numeric coercion * fix numeric coercion * remove comment * initializers * Update README * preserve this with composed transforms * no default sort for hexbin * channel sorting; default sort by descending r * don’t consume null sort * don’t consume null sort, strictly * Update README Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops. I realized everything was wrong when I tested z: null (to have 1 center per position independently of the fill and stroke channels). This should be better 😓