dodge declares output channel #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
added a commit
that referenced
this pull request
Jun 9, 2022
A complement to #930 the X and Y channels should be optional in all the voronoi marks—since d3-delaunay can handle collinear points (and it's not just for the sake of it: the resulting voronoi can be useful, as illustrated in the test case).
mbostock
added a commit
that referenced
this pull request
Jun 10, 2022
* delaunay X and Y are optional A complement to #930 the X and Y channels should be optional in all the voronoi marks—since d3-delaunay can handle collinear points (and it's not just for the sake of it: the resulting voronoi can be useful, as illustrated in the test case). * adopt applyFrameAnchor * one fewer closure Co-authored-by: Mike Bostock <[email protected]>
Member
Author
Merged
backend-devloper
pushed a commit
to backend-devloper/plot
that referenced
this pull request
Nov 24, 2023
* delaunay X and Y are optional A complement to observablehq/plot#930 the X and Y channels should be optional in all the voronoi marks—since d3-delaunay can handle collinear points (and it's not just for the sake of it: the resulting voronoi can be useful, as illustrated in the test case). * adopt applyFrameAnchor * one fewer closure Co-authored-by: Mike Bostock <[email protected]>
tigrevol8888
added a commit
to tigrevol8888/plot
that referenced
this pull request
Jul 5, 2024
* delaunay X and Y are optional A complement to observablehq/plot#930 the X and Y channels should be optional in all the voronoi marks—since d3-delaunay can handle collinear points (and it's not just for the sake of it: the resulting voronoi can be useful, as illustrated in the test case). * adopt applyFrameAnchor * one fewer closure Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one part of #928.
I was hoping there’d be a way to do this for the hexbin transform too, but I couldn’t wrap my head around it. The problem is that the initial options (passed to the Mark constructor) need to declare the channels prior to the initializer running, not the channels after the initializer runs; if we blindly declare the output channels in options, then we’ll overwrite the input channels to the hexbin transform. The dodge transform doesn’t have this problem because it doesn’t have a circular channel dependency (it consumes x and outputs y, or consumes y and outputs x; whereas the hexbin transform consumes x and y and outputs x and y, at a minimum).
Anyway, this seems like an improvement. 🤷