Skip to content

stack #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2021
Merged

stack #99

merged 3 commits into from
Jan 22, 2021

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jan 13, 2021 •
edited
Loading

Relative to the prototype, this handles undefined data and propagates the label, if any, through to the mark definition.

TODO

  • order?
  • offset?
  • Plot.lineY0 and Plot.lineY1 helpers?

@mbostock mbostock requested a review from Fil January 13, 2021 23:02
@Fil
Copy link
Contributor

Fil commented Jan 14, 2021

I've explored stackOrder and stackOffset in https://observablehq.com/@data-workflows/plot-stack-order-offset

It seems to work but it means:

  1. working with Z to create the series (in this test case z = fill = "industry")
  2. going back to the d3-shape version of offset functions, that work with Y, not Y1 Y2.

@mbostock mbostock merged commit 890e727 into main Jan 22, 2021
@mbostock mbostock deleted the mbostock/stack branch January 22, 2021 22:34
@Fil Fil mentioned this pull request Jan 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Awaiting requested review from Fil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil