refactor: create nextOccurrence and nextOccurrenceDate methods in Occurrence

[ilandikov]

Types of changes

Internal changes:

• Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
• Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

• Move Occurrence-related behaviour to Occurrence class

Motivation and Context

• Separate concerns

How has this been tested?

• unit tests

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change has adequate Unit Test coverage.

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[claremacrae]

(I had a longer version of this message but lost the edit...)

I like where this is going.

Any thoughts on Occurrence.ts though?
And also Occurrence.test.ts?

[ilandikov]

Any thoughts on Occurrence.ts though?

Ofc! Extracted in a later commit/PR

[ilandikov]

And also Occurrence.test.ts?

I did some work on this but not much since changing a line of code in current Occurrenceclass triggers test failure in other tests. However there is definitely room for improving the tests after the refactoring is done.

Maybe we can quickly discuss ways to improve the tests on our next session when all the PRs are merged.

[claremacrae]

Great - thanks.

[ilandikov]

Just to clarify, I meant that we/I would do it later, after the refactoring is done, since the code being refactored is covered by tests. So would be good if you find some time to review/approve/merge of this PR =)

[claremacrae]

Understood - am really busy at the moment... But OK, will do it now...

[ilandikov]

Thanks!

[claremacrae]

Merging un-reviewed - please add 'internal' and 'recurring' labels to this and any recent closed ones that I forgot to do this...

[ilandikov]

Merging un-reviewed - please add 'internal' and 'recurring' labels to this and any recent closed ones that I forgot to do this...

Done!