generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 285
fix: Editing properties/frontmatter now updates Query results #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Value not yet checked)
… data The build() method needs to be able to call setCurrentCacheFile() before creating a TaskFile, to prevent warnings from our mock obsidian parseFrontMatterTags() and getAllTags() about inconsistent data.
|
claremacrae
added a commit
that referenced
this pull request
Aug 2, 2024
SonarCloud pointed out that in #3003 I had increased the complexity in Task.identicalTo() from 15 to 16. By this change, and extracting Task.recurrenceIdenticalTo() it should have dropped to below 15 now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix
- non-breaking change which fixes an issue)Internal changes:
test
- additions and improvements to unit tests and the smoke tests)Description
Task
objects are now updated if the frontmatter in the file containing them is edited.Motivation and Context
This fixes an unreleased bug, that editing properties/frontmatter did not update Tasks query results. This matters now that properties/frontmatter can be used in Tasks queries.
The steps to reproduce the bug are:
test
Expected result
Group heading changes to 43:
Actual result
Display is unchanged until edits are made to the task line in the file, or Obsidian is restarted.
How has this been tested?
Checklist
yarn run lint
.Terms