fix: Tasks in renamed files forgot about any properties/frontmatter values in the file

[claremacrae]

Types of changes

Changes visible to users:

• Bug fix (prefix: fix - non-breaking change which fixes an issue - in an unreleased feature)

Internal changes:

• Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)

Description

Fix an unreported bug (in unreleased code)...

The actual fix is c09a884 - the rest is refactoring, initially to make the fix easy, and then to tidy it up a bit, with suggestions from @ilandikov.

Steps to reproduce:

Preparation

1. Install the latest development build, for example from commit b42ead6
2. Create a new note called test 2024-01-23
3. Paste in this content:

---
custom_number_prop: 422
---

- [ ] #task Hellox

4. Create a note called test query
5. Paste in this content:

```tasks
description includes Hellox

group by path
group by function \
    `custom_number_prop: ==${task.file.property('custom_number_prop')}==`
group by scheduled
```

6. View test query in Reading Mode. It should look like this:

Testing

7. Rename test 2024-01-23 to test 2024-01-23 xxx

Expected result

a. The group by path heading gets xxx added
b. The custom_number_prop: heading value remains 422
c. The Backlink name gets xxx added

Actual result

a. ✅ The group by path heading gets xxx added
b. ❌ The custom_number_prop: heading value becomes NULL, not 422
c. ✅ The Backlink name gets xxx added

Motivation and Context

How has this been tested?

• Automated tests
• Exploratory testing

Screenshots (if appropriate)

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• My change has adequate Unit Test coverage.

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud