Skip to content

refactor: introduce parameter object to functions in Suggestor.ts #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 10, 2024
Merged

refactor: introduce parameter object to functions in Suggestor.ts #3022

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
aa060dc
refactor: ! Introduced unused interface SuggestorParameters
claremacrae Aug 10, 2024
798832f
refactor: . Add unused suggestorParameters parameter to addDatesSugge…
claremacrae Aug 10, 2024
8ecf799
refactor: . Add postfix and insertKip to SuggestorParameters
claremacrae Aug 10, 2024
d3d808b
refactor: . Remove dataview parameter from addDatesSuggestions()
claremacrae Aug 10, 2024
0f77e60
refactor: . Remove more parameters from addDatesSuggestions()
claremacrae Aug 10, 2024
264abab
refactor: . Add unused _suggestorParameters parameter to many methods
claremacrae Aug 10, 2024
62b8155
refactor: . Add unused _suggestorParameters parameter to addDependsOn…
claremacrae Aug 10, 2024
e7fded0
refactor: - Add _suggestorParameters parameter to more functions
claremacrae Aug 10, 2024
a32d5c9
refactor: . matchIfCursorInRegex() now uses SuggestorParameters
claremacrae Aug 10, 2024
0ac4430
refactor: . addDependsOnSuggestions() now uses SuggestorParameters
claremacrae Aug 10, 2024
7cedb58
refactor: - unused SuggestorParameters parameter to calculateSkipValu…
claremacrae Aug 10, 2024
9b6c30d
refactor: - calculateSkipValueForMatch() now uses SuggestorParameters…
claremacrae Aug 10, 2024
de02fd3
refactor: - addRecurrenceValueSuggestions() now uses SuggestorParamet…
claremacrae Aug 10, 2024
336070f
refactor: - addIDSuggestion() now uses SuggestorParameters parameter
claremacrae Aug 10, 2024
3c27dcc
refactor: - addPrioritySuggestions() now takes SuggestorParameters pa…
claremacrae Aug 10, 2024
b14c676
refactor: - addTaskLifecycleDateSuggestions() now takes SuggestorPara…
claremacrae Aug 10, 2024
6c67f85
refactor: - filterGeneralSuggestionsForWordAtCursor() now uses Sugges…
claremacrae Aug 10, 2024
30ddf74
refactor: - addTaskPropertySuggestions() now uses SuggestorParameters…
claremacrae Aug 10, 2024
307878b
refactor: . Shorten suggestorParameters to parameters
claremacrae Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading