Skip to content

chore: Fix cloning on Windows #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2024
Merged

chore: Fix cloning on Windows #3029

merged 4 commits into from
Aug 12, 2024

Conversation

claremacrae
Copy link
Collaborator

Types of changes

Changes visible to users:

Internal changes:

  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Description

Remove ? from path, as it is an invalid character in Windows paths.

Motivation and Context

Fix ability to clone on Windows, I hope...

How has this been tested?

Can't test until it's merged.

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae added the type: internal Only regards development or contributing label Aug 12, 2024
Copy link

@claremacrae claremacrae merged commit ce84f69 into main Aug 12, 2024
3 checks passed
@claremacrae claremacrae deleted the fix-cloning-on-windows branch August 12, 2024 18:37
@claremacrae claremacrae changed the title chore: Fix cloning on Windows (I hope) chore: Fix cloning on Windows Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant