[Linux] When exiting the app, the dialog gets put behind the main window

[Tiagoquix]

Operating System Info

Other

Other OS

Fedora Linux 43 KDE

OBS Studio Version

Other

OBS Studio Version (Other)

32.0.4 from Fedora RPMs with a backport (#12951)

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

N/A

Expected Behavior

Dialog should be the focused window.

Current Behavior

When right-click -> Exit in the OBS system tray icon while recording, this dialog appears:

However, it is put behind the main window, requiring to click the taskbar to see the other window of OBS (which is the dialog as presented in the screenshot).

It does not happen on Windows.

Steps to Reproduce

Explained above.

Anything else we should know?

I think this can be solved with a window hint/flag to make it stay on top (so it always gets the most attention and overrides any other apps' focus).

I found this, may be of help (penultimate option at the right-bottom):

https://doc.qt.io/qt-6/qtwidgets-widgets-windowflags-example.html

[mihawk90]

I'm not seeing this on KDE. The main window gets darkened and the dialogue is on top, as expected.

Maybe proper repro steps would help?

Also if your OBS version is using a patch, you should test without said patch to determine whether the issue is with the patch and not OBS in general.

[tytan652]

1. Open OBS Studio
2. Start an output that will make the dialog appear later
3. Hide OBS Studio with the systray menu
4. Exit OBS Studio with the systray menu and see the lack of modal

[Tiagoquix]

Thanks, Tytan. That's exactly it.

[mihawk90]

Well, maybe that is why the Steps to Reproduce section exists, because "Explained above" doesn't work when you didn't mention that you were hiding it in the system tray.

But regardless, can still not reproduce.

But since you skipped the Log as well I can only assume you are on Wayland which is likely where the problem lies then.

[Tiagoquix]

Yes, I thought my explanation was sufficient to understand how to reproduce, but seeing it again I see it wasn't. I am sorry for that.

Indeed, I am on Wayland. Is it different on X11? I didn't know the window order would be affected on Wayland. Can I force XWayland to test somehow? For example, does QT_QPA_PLATFORM=xcb work to test?

What happens is that the dialog to exit appears before the main window. The main window is drawn (appears) after the smaller dialog window, causing the problem.

[mihawk90]

For example, does QT_QPA_PLATFORM=xcb work to test?

You can, but it's not supported and doesn't really say much.

[Tiagoquix]

I tested with QT_QPA_PLATFORM=xcb and indeed the problem does not occur. That is an interesting finding. Thank you.

[hoshinolina]

I can repro on F42 KDE Wayland, when OBS was hidden prior. This does look like a "race" issue, where the windows are stacked in appearance order and the modal is displayed first, so it ends up behind.

Indeed, deferring the modal into the event loop with a QTimer fixes it. Not sure if there is a better way though...

diff --git a/frontend/widgets/OBSBasic.cpp b/frontend/widgets/OBSBasic.cpp
index 69aff5b176d2..c0655fae86db 100644
--- a/frontend/widgets/OBSBasic.cpp
+++ b/frontend/widgets/OBSBasic.cpp
@@ -1696,11 +1696,8 @@ void OBSBasic::closeEvent(QCloseEvent *event)
 		restart = false;
 
 		if (!isClosePromptOpen()) {
-			bool shouldClose = promptToClose();
-
-			if (shouldClose) {
-				closeWindow();
-			}
+			SetShowing(true);
+			QTimer::singleShot( 0, this, &OBSBasic::promptToClose );
 		}
 
 		return;
@@ -1899,8 +1896,11 @@ bool OBSBasic::shouldPromptForClose()
 	return false;
 }
 
-bool OBSBasic::promptToClose()
+void OBSBasic::promptToClose()
 {
+	if (isClosePromptOpen_)
+		return;
+
 	isClosePromptOpen_ = true;
 
 	SetShowing(true);
@@ -1910,11 +1910,12 @@ bool OBSBasic::promptToClose()
 
 	if (button == QMessageBox::Cancel) {
 		isClosePromptOpen_ = false;
-		return false;
+		return;
 	}
 
 	isClosePromptOpen_ = false;
-	return true;
+
+	closeWindow();
 }
 
 void OBSBasic::closeWindow()
diff --git a/frontend/widgets/OBSBasic.hpp b/frontend/widgets/OBSBasic.hpp
index 34490732dcfb..a6550fbee183 100644
--- a/frontend/widgets/OBSBasic.hpp
+++ b/frontend/widgets/OBSBasic.hpp
@@ -335,7 +335,7 @@ public:
 
 protected:
 	bool isReadyToClose();
-	bool promptToClose();
+	void promptToClose();
 
 	virtual void closeEvent(QCloseEvent *event) override;
 	virtual bool nativeEvent(const QByteArray &eventType, void *message, qintptr *result) override;

Also if your OBS version is using a patch, you should test without said patch to determine whether the issue is with the patch and not OBS in general.

It should be obvious by inspection of the PR that it cannot possibly affect any behavior prior to the actual shutdown process (after the modal). We have other patches in Fedora too (codec and browser stuff) but nothing relevant to this bug. I understand the general desire not to deal with downstream changes, but it's not really helpful to ask regular package users to build/install a pristine upstream version as part of the bug report process here. Rather, if you have concerns about downstream patches possibly being relevant, please redirect users to the Fedora bug tracker and us package maintainers can then triage whether it's a downstream or upstream issue.