-
Notifications
You must be signed in to change notification settings - Fork 31
Renaming lockfree #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just commenting here that while there is now a |
It seems that dsds got some traction. I like it. Perhaps, given that it's Domain-safe Data Structures, we can shorten the name to just dds? Also makes it a little easier to pronounce. With dsds I will probably end up calling it just ds in speech quite quickly anyway but I might be splitting hairs here. I like the rest of the proposal:
(Also - I think we should undraft this to encourage others to take a look). |
I generally prefer names that explicitly say what the project does, rather than an abstract name from nowhere that people have to learn and appropriate. It requires less marketing. |
We had a chat about this offline with @lyrm @polytypic @balat a few days ago.
The one thing we ought to decide yet is the name. I don't have strong opinions on this, but I don't know So, we can essentially undraft this after the updates mentioned above and review and merge. Of course we need to settle on a name. :)) |
We talked a bit about the name with folks (cc @lyrm @polytypic @balat @kayceesrk @samoht and more). We've agreed to move forward with renaming the library as It's nice for the name to capture what the library does. But all our other proposals such as |
4c3b87f
to
c35a532
Compare
This PR is finished, I think and need a review (@Sudha247 ?). Several other PRs will come soon to complete it, in particular a refactoring PR to make 2 packages : one with all the data structures and another one with only lockfree data structures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! We're nearly there.
Some minor edit suggestions below. More general questions here -
- Do we want to refer to the library as
Saturn
orsaturn
, in plain text? - I see the module names are changed for
Treiber_stack
toStack
, etc. Do we want to change the file names as well? (stm_triber_stack
, etc.)
Good point.
My thought was : if we ever want to change the default Do you see a better reason for renaming ? |
- Change data structures names for user-ergonomy (treiber_stack -> stack for example) - Uniformize queue interface and doc - Add CONTRIBUTING file and complete test/README.md
Fair enough. The PR looks good to me otherwise. |
TODO list
About this PR
Following a discussion with @bartoszmodelski, @Sudha247 and @polytypic ,
lockfree
is going to be renamed and refactored to include domain safe data structures in general and not just lock free ones.I wrote down what was discussed previously but everything is still open for discussion.
Renaming this repository
Several propositions have been made to rename the repository.
dsds
ordssquare
ordsquare
ords2
for domain safe data structuresSaturn
Any additional opinions about these names are welcomed.
Renaming current data structures
The data structures are going to be renamed following the example of
Java.utils.concurrent
,Rules for naming data structures are the following:
1, The implementations that should be used by default are named the simplest way.
2. The others are named according to their limitations or, if it is not enough, from their specific features.
3. As aliases are easy to use in OCaml, using long but explicit names is alright.
What is not on this PR (and will be in next-to-come PRs)
saturn-lockfree
package with every lockfree data-structures and asaturn
package that includes lockfree data structures and all other non-composable data structures.kcas
repositoryfind
andfind_opt
)