Bug: the Closed/Open state is buggy/confusing

[erikmd]

Related user(s):

@erikmd, @AltGr

Related issue(s) or PR(s):

• Issue Bug: the Closed/Open state should appear for Assigned exercises #534
• PR Various improvements to the teacher page, incl. some inline documentation #549

Related project scope(s):

teacher dashboard

Bug description:

cf. sync.zip

With this zipped sync folder, there are two issues in the teacher dashboard:

1. if we click on the first exercise (demo) then on Open/Close once or several times, it's an unexpected no-op (the badge stays "Assigned", and after clicking on Apply, the sync/exercises.json file does not change either)
2. the second exercise (demo2) is wrongly labelled "Assigned", while the exercise is not included in any assignment anymore.

FTR, here is the contents (pretty-printed with jq) of the file sync/exercises.json:

[
  {
    "learnocaml_version": "2",
    "id": "demo",
    "assignments": {
      "default": {
        "start": 1691877600,
        "stop": 1692482400
      },
      "token_map": {
        "KOK-W3L-NE1-SVY": "Open"
      }
    }
  },
  {
    "learnocaml_version": "2",
    "id": "demo2",
    "assignments": {
      "default": "Closed",
      "token_map": {
        "KOK-W3L-NE1-SVY": "Open"
      }
    }
  }
]

To reproduce:

Steps to reproduce the attached sync.zip

1. Create an empty sync folder
2. Run learn-ocaml build serve --repo=demo-repository from master branch
3. Create a user "Bar"
4. Create a user "Baz"
5. Open the teacher dashboard
6. Add an assignment including both exercises (demo, demo2) and only users (Bar, <any future students>)
7. Click on Apply
8. Click on the assignment, remove exercise demo2
9. Click on Apply

Expected behavior:

No response

learn-ocaml --version

No response

git describe --long --always --abbrev=40 --tags

v0.14.1-39-g48583ba4d1376ad006227d7b5ee1b9cfaf9ad8f7

What OS do you use?

GNU/Linux

What OS version/distribution do you use?

Debian

What browser(s) do you use with learn-ocaml?

Firefox, Chromium

What browser(s) version did you used to reproduce the issue?

Firefox

Screenshots (if need be):

No response

Additional context:

No response

[erikmd]

Good news, I believe I fully fixed these bugs; I'll open a PR just now.