Skip to content

Move to dune 1.7 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2020
Merged

Move to dune 1.7 #357

merged 7 commits into from
Jul 25, 2020

Conversation

maiste
Copy link
Contributor

@maiste maiste commented Jun 25, 2020

Hi,
this PR moves the dune-project from 1.6.3 to 1.7.
For a future feature, dune needs to support dune lang 1.7 to allow to use virtual_modules stanza.

This PR changes the following things:

  • dependency requirements:
    • dune must be >= dune 1.7
    • ipaddr is fixed to 2.8.0 to avoid dependency conflicts
    • lwt is moved to 4.0.0
  • support js_of_ocaml 3.3 and tyxml 4.4.0 and update files to work with
  • remove unused variable errors that stops the compilation with dune new version

@maiste maiste marked this pull request as ready for review June 26, 2020 16:18
@yurug
Copy link
Collaborator

yurug commented Jul 25, 2020

Thank you @maiste !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants