Skip to content

CI/CD using GitHub Actions #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 27, 2020
Merged

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Aug 12, 2020

This PR closes #358. (It also fixes a version metadata in dune-project)

Note: I guess the CI won't start as soon as I open this PR, because it comes from an external fork. See "checklist" below.

Anyway, the experiments I did in the pfitaxel fork (cf. "dry-run" part below) show this will fix #360 (Docker Hub deployment issue).

To sum up, it replaces Travis CI + Docker Hub automated build with GitHub Actions for both CI and CD, keeping the same semantics as much as possible.

Checklist

@yurug below are the steps I have applied to test this PR; you'll need to apply them on your side before merging the PR:

Dry-run

This GitHub Actions configuration gathers four YAML files (there is a little duplication between deploy-*.yml files but it appears GitHub Action doesn't provide yet ways to "include" a YAML in another one):

Comparison with Docker Hub automated build

According to the line cat /proc/cpuinfo /proc/meminfo I've added in (the first stage of) the Dockerfile, it is very possible issue #360 showed up because of lack of RAM:

  • Docker Hub: 1 processor; memory:

    MemTotal:        3997656 kB
    MemFree:         1341656 kB
    MemAvailable:    3380948 kB
    
  • GitHub Actions: 2 processors; memory:

    MemTotal:        7121280 kB
    MemFree:         2074152 kB
    MemAvailable:    6172100 kB
    

erikmd added 7 commits August 11, 2020 22:06
* s/org.label-schema/org.opencontainers.image/

* Set option add_git_labels, which adds:
  - org.opencontainers.image.created
  - org.opencontainers.image.source
  - org.opencontainers.image.revision

href: https://github.com/docker/build-push-action#add_git_labels
* Remove .travis.yml

* Port everything, except Gitter's webhook that might be readded later

* Update Markdown badges
* Add "-j 2" option as well.
* s/pfitaxel/ocaml[-]sf/
* s/staging/master/
@yurug yurug merged commit bcecadd into ocaml-sf:master Aug 27, 2020
@yurug
Copy link
Collaborator

yurug commented Aug 27, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The last Docker Hub build of ocamlsf/learn-ocaml:dev failed [CI] What about migrating to GitHub actions?
2 participants