Fix & Document static deployment CLI support #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Previously, the CLI option was named `--root`. Fortunately, no version of learn-ocaml has been released yet with that previous option naming.
* CLI supports both --root-url flag & LEARNOCAML_ROOT_URL variable
|
@yurug I made several tests, see e.g. https://pfitaxel.github.io/pfitaxel-demo-dev/ for an example of static deployment of this PR (commit 90f391b) on the default demo-repository. and I believe the PR is ready (except the extension of the documentation itself, that may be done in this PR or in another PR?) |
|
@erikmd If you can extend the documentation in this PR, we would be sure that it will not be forgotten... |
erikmd
force-pushed
the
fix-static-deploy
branch
4 times, most recently
from
cef3d42 to
607b90a
Compare
erikmd
force-pushed
the
fix-static-deploy
branch
from
607b90a to
73f56f0
Compare
|
Hi @yurug
Done! here is the direct link so you can proofread :) (btw, sorry for the multiple force-pushes :) |
This comment has been minimized.
This comment has been minimized.
erikmd
changed the title
|
Thank you @erikmd! That's really nice work. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--rootto the more standard name--base-urland accepts aLEARNOCAML_BASE_URLenvironment variable.