Skip to content

Improve UX for learn-ocaml logo #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Conversation

YoanwM
Copy link
Contributor

@YoanwM YoanwM commented Apr 28, 2021

  • fix css so it is more visible when the logo is clickable
  • Update the logo itself

@erikmd
Copy link
Member

erikmd commented Apr 29, 2021

LGTM, thanks @YoanwM ! I guess I can merge this.

FTR, here is a screenshot of the outcome (note that the pointer is now OK when hovering the logo).

Screenshot-i_PR_389

@erikmd erikmd merged commit c406219 into ocaml-sf:master Apr 29, 2021
@erikmd erikmd deleted the logo-click branch April 29, 2021 20:17
@erikmd erikmd self-assigned this Sep 29, 2021
@erikmd erikmd mentioned this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants