Skip to content

Discourage redundant token creation from users #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

AltGr
Copy link
Collaborator

@AltGr AltGr commented Jul 30, 2021

with less obvious new token registration, students should be much more less likely
to create a new token every time (by mistake or laziness)

@erikmd
Copy link
Member

erikmd commented Sep 15, 2021

@AltGr I believe a small rebase is needed for this PR (and maybe, a translation-file regeneration?)

feel free to ask if ever you'd want that I do it! given it may be a bit cumbersome to do… but quite straightforward at the same time ;)

@erikmd erikmd self-assigned this Sep 15, 2021
@erikmd erikmd added the kind: enhancement Enhancement to an existing user-facing feature. label Sep 15, 2021
@erikmd erikmd added this to the learn-ocaml 0.13 milestone Sep 15, 2021
@erikmd erikmd removed their assignment Sep 15, 2021
with less obvious new token registration, students should be much more likely to
create a new token every time (by mistake or laziness)
@AltGr
Copy link
Collaborator Author

AltGr commented Sep 17, 2021

Rebased

@yurug
Copy link
Collaborator

yurug commented Sep 17, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants