QoL: reset the toplevel every time before evaluating code from the editor #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor You might lose what you manually typed directly in the toplevel pane, but that shouldn't be a problem, and most importantly it will avoid already defined ids to clutter the environment. These often cause student confusion with cases like "type t instead of t", or a missing `rec` keyword that compiles because using an older definition.
erikmd
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Very good idea.
I didn't checkout-compile the PR so just a mini-question to be sure before merging:
in line with the principle of "least surprise": will the UI show The toplevel has been reset. (* loading the prelude...*), as if the student had clicked on Reset?
erikmd
added
the
kind: enhancement
Just tested the PR and it's indeed the case:
so I guess I can merge the PR. Thank you Louis for opening this. |
EmileRolley
pushed a commit
to EmileRolley/learn-ocaml
that referenced
this pull request
Sep 16, 2021
…itor (ocaml-sf#411) You might lose what you manually typed directly in the toplevel pane, but that shouldn't be a problem, and most importantly it will avoid already defined ids to clutter the environment. These often cause student confusion with cases like "type t instead of t", or a missing `rec` keyword that compiles because using an older definition.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You might lose what you manually typed directly in the toplevel pane, but that
shouldn't be a problem, and most importantly it will avoid already defined ids
to clutter the environment.
These often cause student confusion with cases like "type t instead of t", or
a missing
reckeyword that compiles because using an older definition.