Skip to content

fix(CI): Use ocaml 4.12.1 #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2021
Merged

fix(CI): Use ocaml 4.12.1 #422

merged 4 commits into from
Sep 26, 2021

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Sep 25, 2021

* Take into account the latest release of ocaml 4.12.x

  href: https://github.com/ocaml/ocaml/releases/tag/4.12.1
* Make it uniform / job(.github/workflows/static-builds.yml : static-bin-macos)

* Add commands to print OS version details

* Don't hardcode `4.12.1` anymore

* Add `opam … -v` flag to ease debugging

* See also https://github.com/coq-community/docker-coq-action#pitfall-do-not-use--use-semicolons
* href: https://formulae.brew.sh/formula/openssl@3#default

* Note: the following two CI builds for macOS are slightly different,
  which allows one to have a better "test coverage":

  - .github/workflows/build-macos.yml : build : 'sh .ci-macosx.sh' =>
    Use a brew distribution of opam

  - .github/workflows/static-builds.yml : static-bin-macos =>
    Use opam-2.1.0-x86_64-macos
@erikmd erikmd added kind: fix kind: infrastructure CI, build tools, development tools labels Sep 25, 2021
@erikmd
Copy link
Member Author

erikmd commented Sep 25, 2021

All learn-ocaml's CI job failures are fixed now, except .github/workflows/static-builds.yml : static-bin-linux : scripts/static-build.sh that relies on the Docker image ocamlpro/ocaml:4.12, which still contains the last-but-one patchlevel release (4.12.0 < 4.12.1).

Hopefully @AltGr will be able to docker-push a new version for ocamlpro/ocaml:4.12

@erikmd erikmd changed the title fix: CI fix(CI): Use ocaml 4.12.1 Sep 25, 2021
@erikmd erikmd added this to the learn-ocaml 0.13 milestone Sep 25, 2021
@erikmd
Copy link
Member Author

erikmd commented Sep 26, 2021

Great, ocamlpro/ocaml:4.12.1 is now available.
So, closing/reopening this PR to restart the CI…

@erikmd erikmd closed this Sep 26, 2021
@erikmd erikmd reopened this Sep 26, 2021
@erikmd
Copy link
Member Author

erikmd commented Sep 26, 2021

Looks good now! so, let's merge this one.

@erikmd erikmd merged commit d13b7a8 into ocaml-sf:master Sep 26, 2021
@erikmd erikmd deleted the fix-ci-4.12 branch September 26, 2021 13:56
@erikmd erikmd self-assigned this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: fix kind: infrastructure CI, build tools, development tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant