Skip to content

refactor: Ensure the uploaded artifacts are single .tar.gz files #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Oct 4, 2021

  • This will be very useful when using a (release-please)-based GHA.

  • and this speeds-up the upload.

@erikmd erikmd added kind: enhancement Enhancement to an existing user-facing feature. kind: infrastructure CI, build tools, development tools labels Oct 4, 2021
@erikmd erikmd added this to the learn-ocaml 0.13.0 milestone Oct 4, 2021
@erikmd
Copy link
Member Author

erikmd commented Oct 4, 2021

The Linux artifact was fine (quickly tested learn-ocaml-client successfully),
but the Darwin one was incomplete (because of symlinks actually 😅)

* This will be very useful when using a (release-please)-based GHA.

* See https://ss64.com/osx/tar.html for the meaning of `tar -h`
@erikmd erikmd force-pushed the improve-static-bin branch from 4fb1fca to 05b5c59 Compare October 4, 2021 22:41
@erikmd
Copy link
Member Author

erikmd commented Oct 4, 2021

This chore/refactor PR is now OK; tested the binaries for Linux another time.

@erikmd erikmd merged commit adbb063 into ocaml-sf:master Oct 4, 2021
@erikmd erikmd deleted the improve-static-bin branch October 4, 2021 23:05
@erikmd erikmd self-assigned this Oct 4, 2021
@erikmd erikmd mentioned this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature. kind: infrastructure CI, build tools, development tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant