Skip to content

Stop using middle button to launch partition #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2023
Merged

Stop using middle button to launch partition #516

merged 2 commits into from
Mar 12, 2023

Conversation

yurug
Copy link
Collaborator

@yurug yurug commented Mar 10, 2023

  • Kind: bugfix / enhancement / feature

Description

Middle button is not a portable notion, especially on Mac OS. This PR
replaces middle button with a composition of key CTRL and left click.

Checklist

Note to maintainers

  • Read this wiki page
  • Make sure the PR has a milestone
  • Assign yourself before merging
  • We can squash-merge 1-commit PRs (use a header with a conventional-commit type, add a footer with Fix #… if need be)

@yurug yurug force-pushed the change-middle-click-to-ctrl-click branch from 3edbcf7 to c28afe3 Compare March 10, 2023 12:53
@erikmd erikmd added kind: enhancement Enhancement to an existing user-facing feature. kind: fix labels Mar 10, 2023
@erikmd
Copy link
Member

erikmd commented Mar 12, 2023

@yurug a patch was needed; tested successfully in (Firefox | Safari) on macOS; will merge as soon as the CI concludes.

@erikmd
Copy link
Member

erikmd commented Mar 12, 2023

FTR: this JS thread was helpful: https://stackoverflow.com/a/5500536/9164010

erikmd and others added 2 commits March 13, 2023 00:01
@erikmd
ci(macos): Fix brew upgrade failure, bis
c6300b0
@yurug @erikmd
fix(partition-view): Use Ctrl-click or ⌘-click (instead of middle-click)
3820c5b 
This new key-binding is macOS-compliant (tested with both Firefox and Safari).

Co-Authored-By: Yann Regis-Gianas <[email protected]>
Co-Authored-By: Érik Martin-Dorel <[email protected]>
@erikmd erikmd force-pushed the change-middle-click-to-ctrl-click branch from efdff15 to 3820c5b Compare March 12, 2023 23:20
@erikmd erikmd mentioned this pull request Mar 12, 2023
Merged
4 tasks
@erikmd erikmd self-assigned this Mar 12, 2023
@erikmd erikmd merged commit a6e4c5e into master Mar 12, 2023
@erikmd erikmd deleted the change-middle-click-to-ctrl-click branch March 12, 2023 23:44
@github-actions github-actions bot mentioned this pull request Mar 12, 2023
Merged
@erikmd erikmd added this to the learn-ocaml 1.0.0 milestone Mar 19, 2023
@erikmd erikmd mentioned this pull request Mar 21, 2023
Open
@erikmd erikmd mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erikmd erikmd

Labels
kind: enhancement Enhancement to an existing user-facing feature. kind: fix
Projects
None yet
Milestone
learn-ocaml 0.15.0
Development

Successfully merging this pull request may close these issues.

Bug: partition-view is unavailable on macOS
2 participants
@yurug @erikmd