bug: two implementation details are fragile in partition-view#550
Open
Plictox wants to merge 5 commits intoocaml-sf:masterfrom
Open
bug: two implementation details are fragile in partition-view#550Plictox wants to merge 5 commits intoocaml-sf:masterfrom
Plictox wants to merge 5 commits intoocaml-sf:masterfrom
Conversation
Collaborator
|
Thanks @Plictox! Note BTW: the standard convention for assignees in GitHub public repositories is generally as follows: → The developer that implements the feature (you) is the assignee of the issue (#456) → The maintainer that reviews the contribution (me) is the assignee of the PR (#550) : updating this now. Have a nice WE and see you. |
added 2 commits
May 10, 2023 13:52
…-partition-requests * origin/bug-partition-requests: bug: passing eid as an argument for Partition requests
erikmd
reviewed
May 10, 2023
Collaborator
erikmd
left a comment
There was a problem hiding this comment.
Thanks! some first suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Note to maintainers
Close #…if a related issue exists.