Skip to content

Fix and improve make update-fr-translation #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Aug 25, 2023

Description

Fix and improve make update-fr-translation

Checklist

Note to maintainers

  • Read this wiki page.
  • Make sure the PR has a milestone.
  • Assign yourself before merging.
  • Either do a regular merge:
    • for PRs containing several commits following conventional-commits,
    • or for PRs containing 1 commit shared with a later PR (to preserve the SHA1)
  • Or do a squash-merge:
    • for PRs containing only 1 commit (not shared with a later PR),
    • or for PRs containing several commits that need not be kept in the history;
    • Update the commit message header with a conventional-commit type,
    • Add a footer Close #… if a related issue exists.

@erikmd erikmd changed the title Fix po Fix and improve make update-fr-translation Aug 25, 2023
@erikmd erikmd added this to the learn-ocaml 0.15.1 milestone Aug 25, 2023
@erikmd erikmd requested review from yurug and AltGr August 25, 2023 11:49
@erikmd
Copy link
Member Author

erikmd commented Aug 28, 2023

I believe this small bugfix PR can be merged without discussion, all the more as it is consistent with @yurug's remark in
#548 (comment)

@erikmd erikmd self-assigned this Aug 28, 2023
@erikmd erikmd merged commit b4d68e8 into ocaml-sf:master Aug 28, 2023
@erikmd erikmd deleted the fix-po branch August 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: file translations/fr.po.header is missing
1 participant