Skip to content

ci: Fix jekyll-build-pages source for https://ocaml-sf.org/learn-ocaml/ #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Dec 11, 2023

Description

the merge of #576 slightly broke the deployment of the regular website on https://ocaml-sf.org/learn-ocaml/
in particular this link does not work anymore: https://ocaml-sf.org/learn-ocaml/howto-deploy-learn-ocaml-statically

I believe this is because the gh pages source has been set to ./ instead of ./docs,
so the HTML index unexpectedly comes from the README.md, instead of docs/index.md

@AltGr do you think this patch will work out-of-the-box as is, or I need to tweak another path?

If you're not sure, this can be tested after-the-fact anyway…

Checklist

Note to maintainers

  • Read this wiki page.
  • Make sure the PR has a milestone.
  • Assign yourself before merging.
  • Either do a regular merge:
    • for PRs containing several commits following conventional-commits,
    • or for PRs containing 1 commit shared with a later PR (to preserve the SHA1)
  • Or do a squash-merge:
    • for PRs containing only 1 commit (not shared with a later PR),
    • or for PRs containing several commits that need not be kept in the history;
    • Update the commit message header with a conventional-commit type,
    • Add a footer Close #… if a related issue exists.

@AltGr
Copy link
Collaborator

AltGr commented Dec 12, 2023

Let's try it, there is no other way to check if it works anyway ^^

@AltGr AltGr merged commit 9cf5486 into ocaml-sf:master Dec 12, 2023
@AltGr
Copy link
Collaborator

AltGr commented Dec 12, 2023

Your fix worked 🎉
I also had to fix the OSX CI, but it had got broken by outside world changes.

@erikmd
Copy link
Member Author

erikmd commented Dec 12, 2023

OK, thanks a lot @AltGr !

@erikmd erikmd deleted the fix-ghp branch December 16, 2023 23:50
@erikmd erikmd added this to the learn-ocaml 1.0.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants