Skip to content

liquid_*.0.1.2 missing v bounds#28225

Merged
shonfeder merged 5 commits intoocaml:masterfrom
jmid:liquid-missing-v-bounds
Jul 24, 2025
Merged

liquid_*.0.1.2 missing v bounds#28225
shonfeder merged 5 commits intoocaml:masterfrom
jmid:liquid-missing-v-bounds

Conversation

@jmid
Copy link
Member

@jmid jmid commented Jul 22, 2025

This adds a missing v in the bounds of the liquid_*.0.1.2 packages.
The corresponding change for the 0.1.1 release was done in 1728e1e.
I've just filed a PR to upstream the change here: benfaerber/liquid-ml#3

@jmid
Copy link
Member Author

jmid commented Jul 22, 2025

This fails on

  • FreeBSD (due to re2 requiring conf-g++ and failing in one of the 2 or with a Bad file descriptor in ppx_inline_test)
  • Windows

None of these were caused by adding missing vs in bounds.
As such this should be good to go.

@shonfeder
Copy link
Member

Thank you for the fixes!

@shonfeder shonfeder merged commit fb4de1d into ocaml:master Jul 24, 2025
1 of 3 checks passed
@jmid jmid deleted the liquid-missing-v-bounds branch July 24, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants