[new release] passage (0.1.8)

[thatportugueseguy]

Passage - used to store and manage access to shared secrets

• Project page: https://github.com/ahrefs/passage

CHANGES:

• deep refactor of the code
  • more code moved to the lib, cleaner main.ml file
  • more abstractions, less indirection
  • updated the editor for reusability and robustness
  • removed lwt, since we don't really have true async code
  • use bos for command running and stdin/stdout/stderr handling
• removed lwt
• updated completions (bash and zsh)

[raphael-proust]

The CI is somewhat unconvincing:

There are some issues like

passage.0.1.8 is not installed. Install it? [Y/n] y
  * Missing dependency:
    - passage >= 0.1.8 -> devkit >= 1.20240429 -> pcre -> conf-libpcre
    depends on the unavailable system package 'libpcre3-dev'. Use `--no-depexts' to attempt installation anyway, or it is possible that a depext package name in the opam file is incorrect.

We need to update conf-libpcre in a separate PR to improve this probably.

Otherwise, some tests fail with

### output ###
# File "tests/replace_comment_command.t", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/tests/replace_comment_command.t _build/default/tests/replace_comment_command.t.corrected
# diff --git a/_build/default/tests/replace_comment_command.t b/_build/default/tests/replace_comment_command.t.corrected
# index c30dc85..07087bd 100644
# --- a/_build/default/tests/replace_comment_command.t
# +++ b/_build/default/tests/replace_comment_command.t.corrected
# @@ -29,34 +29,28 @@ Should succeed - replacing single-line comments with multiline comments
#    $ passage cat 00/secret1
#    (00/secret1) secret: single line
#    
# -  replaced again comments
# -  line 2
# +  replaced again comments\nline 2
[…]

Is that a known issue? There seem to be some escaping issues maybe? or printing errors?

[thatportugueseguy]

IIUC these are two different issues:

• pcre dep issue is related to trixie not having the same set of pcre packages available as bookworm. This is something we'll work around by installing libpcre3-dev on our machines. We don't expect to have external users for this tool.
• the tests thing is related to how some distros and OS's (eg macos) handle these kinds of characters. It's come up in the past, and we don't care about those use cases.

These are known issues and accounted for, thank you

[raphael-proust]

I made #28769 to improve the error message on debian when conf-libpcre fails to build.

I'll try to figure out the test issues later.