Skip to content

Pervasives.compare : different semantic with abstract value #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hhugo opened this issue Dec 23, 2013 · 1 comment
Closed

Pervasives.compare : different semantic with abstract value #65

hhugo opened this issue Dec 23, 2013 · 1 comment

Comments

@hhugo
Copy link
Member

hhugo commented Dec 23, 2013

comparing 2 different Weak.t will succeed with js_of_ocaml where it should raise an exception.
We should either fix the runtime or document the deviation.
@hhugo
Copy link
Member Author

hhugo commented Mar 6, 2014

@vouillon, any thoughts ?
I would fix the runtime and raise exceptions when needed.
I've had issues in the past, comparing React.signal with the default comparison. Weak.t inside React.signal were introducing cycles (comparing never stops)

vouillon added a commit that referenced this issue Oct 29, 2024
@vouillon
Merge pull request #65 from OlivierNicole/converge-jsoo-merge-02
56919bc 
Integrate "added 'ellipse' method to canvasRenderingContext2D" (#1555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hhugo