Skip to content

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Oct 26, 2024

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 25 changed files in this pull request and generated no comments.

Files not reviewed (18)
  • compiler/bin-js_of_ocaml/build_fs.ml: Language not supported
  • compiler/bin-js_of_ocaml/cmd_arg.ml: Language not supported
  • compiler/bin-js_of_ocaml/cmd_arg.mli: Language not supported
  • compiler/bin-js_of_ocaml/compile.ml: Language not supported
  • compiler/lib/code.ml: Language not supported
  • compiler/lib/driver.ml: Language not supported
  • compiler/lib/driver.mli: Language not supported
  • compiler/lib/flow.ml: Language not supported
  • compiler/lib/flow.mli: Language not supported
  • compiler/lib/ocaml_compiler.ml: Language not supported
  • compiler/lib/ocaml_compiler.mli: Language not supported
  • compiler/lib/parse_bytecode.ml: Language not supported
  • compiler/lib/pure_fun.ml: Language not supported
  • compiler/lib/shape.ml: Language not supported
  • compiler/lib/shape.mli: Language not supported
  • compiler/lib/specialize.ml: Language not supported
  • compiler/tests-compiler/sourcemap.ml: Language not supported
  • compiler/tests-full/dune: Language not supported

@OlivierNicole
Copy link
Contributor

Do we have an idea of the scale of the performance gains that could be made with this?

@hhugo hhugo force-pushed the hints branch 3 times, most recently from 05038ee to c0a5831 Compare June 16, 2025 08:32
@hhugo
Copy link
Member Author

hhugo commented Jun 16, 2025

Do we have an idea of the scale of the performance gains that could be made with this?

I don't know exactly, I've rebased the PR and its ocaml companion https://github.com/hhugo/ocaml/tree/optimization-hints but we can't currently run the benchmarks with OCaml 5.3 (see #2035)

@hhugo hhugo force-pushed the hints branch 2 times, most recently from 96fe9c4 to 4aaf531 Compare June 20, 2025 12:09
@hhugo hhugo force-pushed the hints branch 4 times, most recently from 328b878 to f790a59 Compare July 9, 2025 20:42
@vouillon vouillon force-pushed the hints branch 2 times, most recently from 6627ba4 to ba5f72f Compare July 18, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants