Dom_html: fix the type of some properties and methods #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many properties are now specified to be numbers rather than integers. https://drafts.csswg.org/cssom-view/#extensions-to-the-mouseevent-interface https://w3c.github.io/touch-events/#dom-touch
vouillon
added a commit
to ocsigen/eliom
that referenced
this pull request
Nov 27, 2024
Adapt to Dom_html API change (ocsigen/js_of_ocaml#1747).
This was referenced Nov 27, 2024
hhugo
added a commit
to hhugo/opam-repository
that referenced
this pull request
Feb 7, 2025
CHANGES: ## Features/Changes * Compiler/Runtime: Make resuming a continuation more efficient in js (ocsigen/js_of_ocaml#1765) * Compiler/Runtime: Effects: add an optional feature of "dynamic switching" between CPS and direct style, resulting in better performance when no effect handler is installed * Compiler: Merged Wasm_of_ocaml (ocsigen/js_of_ocaml#1724) * Lib: fix the type of some DOM properties and methods (ocsigen/js_of_ocaml#1747) * Lib: removed no longer relevant Js.optdef type annotations (ocsigen/js_of_ocaml#1769) * Lib: Add other textMetrics property (ocsigen/js_of_ocaml#1784) * Lib: rename Firebug to Console (ocsigen/js_of_ocaml#1802) * Test: use dune test stanzas (ocsigen/js_of_ocaml#1631) * Test: run wasm tests on windows * Misc: drop support for IE * Misc: move tests to OCaml 5.3 * Misc: import many test from the OCaml codebase * Runtime: support for float16 bigarrays * Runtime: support more Unix functions (ocsigen/js_of_ocaml#1823) * Runtime: various filesystem fixes (ocsigen/js_of_ocaml#1825) ## Bug fixes * Compiler: Fix small bug in global data flow analysis (ocsigen/js_of_ocaml#1768) * Runtime: no longer leak channels * Runtime: Fix Marshal.to_buffer (ocsigen/js_of_ocaml#1798) * Runtime: unmarshalling objects should refresh its id * Runtime: check size upper bound during array creation * Runtime: return sys_error when reading from a closed channels * Runtime: fix parsing of hex-float with very large exponent * Runtime: make sure [n / 0L] is not optimized away by DCE * Runtime: fix Unix.LargeFile.stat/lstat * Runtime: fix stat/lstat times * Runtime: fix reading from stdin in an interactive nodejs
hhugo
pushed a commit
to ocsigen/eliom
that referenced
this pull request
Mar 5, 2025
Adapt to Dom_html API change (ocsigen/js_of_ocaml#1747).
hhugo
pushed a commit
to ocsigen/eliom
that referenced
this pull request
Mar 5, 2025
Adapt to Dom_html API change (ocsigen/js_of_ocaml#1747).
vouillon
added a commit
to kit-ty-kate/eliom
that referenced
this pull request
Apr 22, 2025
Adapt to Dom_html API change (ocsigen/js_of_ocaml#1747).
smorimoto
pushed a commit
to kit-ty-kate/eliom
that referenced
this pull request
Apr 22, 2025
Adapt to Dom_html API change (ocsigen/js_of_ocaml#1747).
smorimoto
pushed a commit
to kit-ty-kate/eliom
that referenced
this pull request
Apr 22, 2025
Adapt to Dom_html API change (ocsigen/js_of_ocaml#1747).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some properties and methods have been redefined to be numbers rather than just numbers.
This partially addresses #1719.