Skip to content

Improved optimization pass scheduling #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 6, 2025
Merged

Improved optimization pass scheduling #1962

merged 11 commits into from
May 6, 2025

Conversation

vouillon
Copy link
Member

@vouillon vouillon commented May 5, 2025

No description provided.

@vouillon vouillon force-pushed the optim-scheduling branch from 336813b to 68e32fe Compare May 5, 2025 10:14
@hhugo
Copy link
Member

hhugo commented May 5, 2025

I was playing with the same idea and got the same diffs in the tests, do you understand where they come from ?

@vouillon
Copy link
Member Author

vouillon commented May 5, 2025

I was playing with the same idea and got the same diffs in the tests, do you understand where they come from ?

It's because we add a phi pass before the first deadcode pass. So the name of some variables which are actually unused get propagated to previous variables.

@hhugo hhugo force-pushed the optim-scheduling branch from f657552 to d01a127 Compare May 5, 2025 14:33
@hhugo
Copy link
Member

hhugo commented May 5, 2025

@vouillon, I've rebased your branch and made some changes to accommodate the new check

@vouillon vouillon marked this pull request as ready for review May 5, 2025 15:10
@hhugo hhugo force-pushed the optim-scheduling branch from c25ba17 to 2ef43b1 Compare May 5, 2025 21:18
@hhugo
Copy link
Member

hhugo commented May 6, 2025

It's a bit difficult to analyze the benchmarks for this PR because the number of optimization passes is now different.

The only noticeable regression is with Fiat-Crypto, phi + flow went from 12s to 17s. I don't know if we can do anything about it.

@hhugo hhugo mentioned this pull request May 6, 2025
@hhugo
Copy link
Member

hhugo commented May 6, 2025

Can you also add a Changelog entry

vouillon added 2 commits May 6, 2025 14:42
It is expensive and does not bring much
@vouillon
Copy link
Member Author

vouillon commented May 6, 2025

The only noticeable regression is with Fiat-Crypto, phi + flow went from 12s to 17s. I don't know if we can do anything about it.

I have pushed a commit to skip the phi simplification pass in the first round. It is expensive (since blocks still have a lot of parameters) and not very helpful.

@hhugo hhugo mentioned this pull request May 6, 2025
@hhugo hhugo merged commit eb3064d into master May 6, 2025
25 of 26 checks passed
@hhugo hhugo deleted the optim-scheduling branch May 6, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants