Skip to content

Conversation

@octet-stream
Copy link
Owner

@octet-stream octet-stream commented May 2, 2022

  • Move to ESM
  • Remove FormData entries argument from constructor and corresponding interface
  • Use string | Blob type in set/append methods. Reverted to unknown
  • Set minimal Node.js version to 14.18 (might be adjusted before release)
  • Mention support for Node.js' blob implementation and recommend to use that or fetch-blob instead of our own implementation, because it will be gone in a future releases.
  • Add tests with native Node.js Blob

Resolves #49

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #55 (50586bd) into master (3e8109a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         8    -1     
  Lines          996       973   -23     
  Branches       137       145    +8     
=========================================
- Hits           996       973   -23     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/isFunction.ts 100.00% <ø> (ø)
src/isPlainObject.ts 100.00% <ø> (ø)
src/Blob.ts 100.00% <100.00%> (ø)
src/File.ts 100.00% <100.00%> (ø)
src/FormData.ts 100.00% <100.00%> (ø)
src/blobHelpers.ts 100.00% <100.00%> (ø)
src/fileFromPath.ts 100.00% <100.00%> (ø)
src/isFile.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8109a...50586bd. Read the comment docs.

@octet-stream octet-stream self-assigned this May 7, 2022
@octet-stream octet-stream marked this pull request as ready for review June 12, 2022 01:16
@octet-stream octet-stream merged commit b7b3444 into master Jun 12, 2022
@octet-stream octet-stream deleted the esm branch June 12, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v5 Roadmap

2 participants