Skip to content

build(deps): updates all node versions in workflows and package.json to v18 #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

nickfloyd
Copy link
Contributor

While this change is not technically required as part of our efforts to drop support for NodeJS v14, v16 - this does help to get all of our packages and tooling in sync with a consistent node version.

Part of: octokit/octokit.js#2486


Behavior

Before the change?

  • We were using node v16 in our test workflow
  • We are using node >= 16 in our package.json
  • The package-lock.json is currently at version 2

After the change?

  • We are now using node v18 in our test workflow
  • We are now using node >= 18 in our package.json
  • The package-lock.json is now at version 3

@nickfloyd nickfloyd merged commit 10f0099 into main Jun 26, 2023
@nickfloyd nickfloyd deleted the update-node-in-workflows branch June 26, 2023 20:35
@octokitbot
Copy link
Contributor

🎉 This PR is included in version 12.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants