Bump Android FBSDK Core Kit, bump iOS FBAudienceNetwork, and merge debug option #436
Conversation
Update iOS FBAudienceNetwork to using optimistic version from 6.16 Update example folder
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the plugin version and underlying Facebook SDKs, and merges in an option to enable debug logging when setting advertiser tracking.
- Version bump to 0.19.8 in pubspec and CHANGELOG
- Update iOS
FBAudienceNetworkdependency to a flexible range - Update Android SDK range and add debug/logging behavior in
setAdvertiserTracking
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Bumped plugin version from 0.19.7 to 0.19.8 |
| lib/facebook_app_events.dart | Simplified doc comment for setAdvertiserTracking |
| ios/facebook_app_events.podspec | Changed FBAudienceNetwork dependency to ~> 6.16 |
| android/src/main/kotlin/.../FacebookAppEventsPlugin.kt | Imported LoggingBehavior and implemented debug logging in handler |
| android/build.gradle | Enabled buildConfig and bumped facebook-android-sdk to [18.0,19.0) |
| CHANGELOG.md | Added 0.19.8 section with summary of updates |
Comments suppressed due to low confidence (2)
android/src/main/kotlin/id/oddbit/flutter/facebook_app_events/FacebookAppEventsPlugin.kt:104
- The new
handleSetAdvertiserTrackinglogic lacks unit or integration tests. Consider adding tests to verify bothenabledandcollectIdbehaviors on Android.
private fun handleSetAdvertiserTracking(call: MethodCall, result: Result) {
android/src/main/kotlin/id/oddbit/flutter/facebook_app_events/FacebookAppEventsPlugin.kt:17
- Missing import for
FacebookSdk; ensure you importcom.facebook.FacebookSdkto avoid unresolved reference errors.
import com.facebook.LoggingBehavior
ios/facebook_app_events.podspec
Outdated
| # See docs on FBAudienceNetwork | ||
| # https://developers.facebook.com/docs/audience-network/setting-up/platform-setup/ios/add-sdk/ | ||
| s.dependency 'FBAudienceNetwork', '6.16' | ||
| s.dependency 'FBAudienceNetwork', '~> 6.16' |
There was a problem hiding this comment.
Podspec dependency uses ~> 6.16, which allows updates from 6.16 but doesn’t explicitly bump to 6.17. To reflect an optimistic 6.17, consider using ~> 6.17 or adjusting the lower bound accordingly.
| s.dependency 'FBAudienceNetwork', '~> 6.16' | |
| s.dependency 'FBAudienceNetwork', '~> 6.17' |
android/src/main/kotlin/id/oddbit/flutter/facebook_app_events/FacebookAppEventsPlugin.kt
Show resolved
Hide resolved
android/src/main/kotlin/id/oddbit/flutter/facebook_app_events/FacebookAppEventsPlugin.kt
Show resolved
Hide resolved
|
I'm asking why the Facebook Audience Network dependency is added at all? |
|
@qeepcologne yes, it is added on iOS podspec for iOS build |
antonoddbit
changed the title
Version changed to 0.20.0 due to breaking changes iOS FBAudienceNetwork podspecs Update example pubspec
Thank you for a sharp observation @qeepcologne . We're taking a better look at this to understand if it should be part of the package at all.
|
- Remove FBAudienceNetwork dependency from iOS implementation - Keep Facebook analytics functionality through FBSDKCoreKit - Update version to 0.20.0 on iOS podspec BREAKING CHANGE: If your app requires FBAudienceNetwork framework, you'll need to include it as a separate dependency in your project.
| @@ -1,3 +1,11 @@ | |||
| ## 0.20.0 | |||
| ### ⚠️ Breaking Changes | |||
| - **Remove iOS FBAudienceNetwork dependency** - If your app depends on FBAudienceNetwork framework, you'll need to include it separately in your app | |||
FBSDKCoreKitto version18.0to19.06.17