Whitelist origin & Ng waitForApi fix

[Hengjie]

Fixes #18
Fixes #17

[Hengjie]

No problem with adding tests, but how do you run them?

[ofirdagan]

After you run

bower install
npm install

you should run

grunt serve

This will run a local server on port 9000 and will run the unit tests on each file save.
let me know if you need any help.

[Hengjie]

I've pushed some fixes based on your comments. I'm having trouble running specs, right now it's output is:

cross-domain-local-storage aaaaaaaaaa$ grunt karma:unit
Running "karma:unit" (karma) task
WARN [watcher]: Pattern "/Users/aaaaaaaaaa/Development/cross-domain-local-storage/bower_components/jquery/jquery.js" does not match any file.
WARN [watcher]: Pattern "/Users/aaaaaaaaaa/Development/cross-domain-local-storage/{app,.tmp}/*.js" does not match any file.
INFO [karma]: Karma v0.12.37 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket y-J1aqY90khSlzMv3317 with id 40364913
PhantomJS 1.9.8 (Mac OS X 0.0.0) xdLocalStorage test should get item after init FAILED
  Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 6 of 6 (1 FAILED) (5.003 secs / 5.01 secs)
Warning: Task "karma:unit" failed. Use --force to continue.

Aborted due to warnings.


Execution Time (2015-08-21 01:28:55 UTC)
karma:unit  6.9s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 100%
Total 6.9s

cross-domain-local-storage aaaaaaaaaa$

[Hengjie]

What's odd is that init works fine when I'm testing on staging env.

[ofirdagan]

if you run

grunt serve --force

then you can debug the test if you open the browser on this page: localhost:8880/debug.html

I'll try to take a look and see what does this test fails

[gligoran]

How come this never got merged in? The allowed origin functionality would be really nice to have.

[Hengjie]

Because I didn't have specs for it. I no longer have time to write specs, can someone please take over it?

I agree, I think the changes are rather important since origin whitelisting is a best practice for xd communication.

[ofirdagan]

it has a branch conflict. once it's resolved I'll merge it in

[Hengjie]

@ofirdagan would you be okay to merge without specs if the conflicts were resolved?

[ofirdagan]

yup