Add NVM prompt#207
Merged
bobthecow merged 3 commits intooh-my-fish:masterfrom Jul 1, 2019
Merged
Conversation
alessandro-fazzi
force-pushed
the
prompt_nvm
branch
from
b9df90f to
67ae446
Compare
Contributor
Author
|
Sry for the push-force, but I've rebased after a fixup in order to retain clean history: I left a debug |
Contributor
Author
|
I've opted to not show the prompt also if |
bobthecow
requested changes
Jun 30, 2019
Member
bobthecow
left a comment
bobthecow
left a comment
There was a problem hiding this comment.
👍
That's the approach I usually take to colors :)
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says. Should fix #97
Sincerly I'm not 100% sure about colors I've used for all the themes: I chose the green and applied it down to all the supported color schemes.
Since this is a PR on a project I do not maintain, I decided to have this prompt disabled by default.
If NVM version is deactivated (
nvm deactivate) the nvm prompt won't show. I'm open to other/smarter methods to understand if we're not on an nvm's node version.Documentation should be ok also.
Note: this is a specific PR done for NVM, hence it's not meant to supersede the (stalled?) #128