Remove space after virtualenv glyph so version is connected to it#76
Open
JelteF wants to merge 1 commit intooh-my-fish:masterfrom
Open
Remove space after virtualenv glyph so version is connected to it#76JelteF wants to merge 1 commit intooh-my-fish:masterfrom
JelteF wants to merge 1 commit intooh-my-fish:masterfrom
Conversation
Member
|
Mind adding a before / after screenshot? |
Contributor
Author
Member
Contributor
Author
|
Hmm weird, is it considered as a single or double width character for you. Also, what terminal and OS do you have? I'm runnig Arch linux with xfce4-terminal |
Member
|
I'm using iTerm2 on OS X. There's a setting in iTerm to "Treat ambiguous-width characters as double width", and ticking that makes it act like yours. But it very not recommended to enable this option :) Maybe we need a theme config to set for people whose terminals treat these glyphs as double width. Are you seeing extra space around other glyphs as well? |
Contributor
Author
Member
|
I think we need to have a setting for whether to include spaces after certain glyphs. Some shells will never look good with the spaces, some shells will never look good without them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






No description provided.