Skip to content

refactor(header): improve IndexMap implementation (into ByteArrayMap) and fix benches #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kanarus merged 6 commits into from
Aug 27, 2025
Merged

refactor(header): improve IndexMap implementation (into ByteArrayMap) and fix benches #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc52642
refactor `header::{IndexMap => ByteArrayMap}`
kanarus Aug 25, 2025
5cc392e
introduce `ByteArrayMap::insert_new` and use it in `ResponseHeaders::…
kanarus Aug 25, 2025
972405c
update bench
kanarus Aug 25, 2025
b041e26
update bench
kanarus Aug 25, 2025
16324c4
update response_headers bench
kanarus Aug 25, 2025
68e0a4b
fix phrases and update some
kanarus Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions benches/benches/request_headers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,34 +84,32 @@ fn input() -> Vec<u8> {
#[bench] fn ohkami_parse(b: &mut test::Bencher) {
let input = input();

b.iter(|| {
b.iter(|| -> RequestHeaders {
let mut r = byte_reader::Reader::new(black_box(input.as_slice()));

let mut h = RequestHeaders::_init();
while r.consume("\r\n").is_none() {
let key_bytes = r.read_while(|b| b != &b':');
r.consume(": ").unwrap();

let value = CowSlice::Ref(Slice::from_bytes(r.read_while(|b| b != &b'\r')));
r.consume("\r\n").unwrap();

if let Some(key) = RequestHeader::from_bytes(key_bytes) {
h._insert(key, CowSlice::Ref(
Slice::from_bytes(r.read_while(|b| b != &b'\r'))
));
h._append(key, value);
} else {
match key_bytes {
b"Cookie" | b"cookie" => (/* skip now */),
_ => h._insert_custom(Slice::from_bytes(key_bytes), CowSlice::Ref(
Slice::from_bytes(r.read_while(|b| b != &b'\r'))
))
}
h._insert_custom(Slice::from_bytes(key_bytes), value)
}
r.consume("\r\n");
}

h
})
}

#[bench] fn fxmap_parse(b: &mut test::Bencher) {
let input = input();

b.iter(|| {
b.iter(|| -> FxMap {
let mut r = byte_reader::Reader::new(black_box(input.as_slice()));

let mut h = FxMap::new();
Expand All @@ -124,13 +122,15 @@ fn input() -> Vec<u8> {
));
r.consume("\r\n");
}

h
})
}

#[bench] fn headerhashmap_parse(b: &mut test::Bencher) {
let input = input();

b.iter(|| {
b.iter(|| -> HeaderHashMap {
let mut r = byte_reader::Reader::new(black_box(input.as_slice()));

let mut h = HeaderHashMap::default();
Expand All @@ -143,13 +143,15 @@ fn input() -> Vec<u8> {
));
r.consume("\r\n");
}

h
})
}

#[bench] fn http_crate_parse(b: &mut test::Bencher) {
let input = input();

b.iter(|| {
b.iter(|| -> HeaderMap {
let mut r = byte_reader::Reader::new(black_box(input.as_slice()));

let mut h = HeaderMap::new();
Expand All @@ -162,13 +164,15 @@ fn input() -> Vec<u8> {
);
r.consume("\r\n");
}

h
})
}

#[bench] fn header_hashbrown_parse(b: &mut test::Bencher) {
let input = input();

b.iter(|| {
b.iter(|| -> HeaderHashBrown::<false> {
let mut r = byte_reader::Reader::new(black_box(input.as_slice()));

let mut h = HeaderHashBrown::<false>::new();
Expand All @@ -183,5 +187,7 @@ fn input() -> Vec<u8> {
None => h.insert_from_reqbytes(key_bytes, value_bytes),
};
}

h
})
}
Loading