Added authenticate filter. #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rganisation there is no need to redirect end user to open-id server. It must be possible to login with username and password on wordpress site. 'Direct Access Grants' have to be enabled for client. This option is disabled by default. made plugin to singleton. It would be good to have an access to settings without reading and parsing options.
daggerhart
reviewed
Jul 21, 2019
| else { | ||
| wp_redirect( home_url() ); | ||
|
|
||
| if ( is_null($user) || is_wp_error($user) && $user->get_error_code() === 'invalid_username' ) { |
Collaborator
There was a problem hiding this comment.
I need a little clarity on this check. Do we want to test for the exact message 'invalid_username' here?
Implication being that we only send a remote authentication request if the provided username doesn't exist in WP?
Contributor
Author
There was a problem hiding this comment.
You are right.
In current implementation (priority 15) makes this check no sense. Its make sense only if this filter runs after the default wordpress authenticator (priority 20). the default returns this WP_Error if a user not found in [prefix_]users table.
Q: What would be better here?
- to modify this code and remove this check.
- to allow administrator to set this priority on settings page? (default 15)
6 tasks
timnolte
added
duplicate
and removed
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Identity Provider belongs to the same organisation there is no need to redirect end user to open-id server. It must be possible to login with username and password on wordpress site. 'Direct Access Grants aka grant_type=password' have to be enabled for client. This option is disabled by default.
made plugin to singleton. It would be good to have an access to settings without reading and parsing options.