Revert "mcs: fix RegionsId is not properly set (tikv#9483)"

This reverts commit 74e0bbc.

Author: okJiang

server/grpc_service.go

@@ -2482,7 +2482,6 @@ func convertSplitResponse(resp *schedulingpb.SplitRegionsResponse) *pdpb.SplitRe
 	return &pdpb.SplitRegionsResponse{
 		Header:             convertHeader(resp.GetHeader()),
 		FinishedPercentage: resp.GetFinishedPercentage(),
-		RegionsId:          resp.GetRegionsId(),
 	}
 }
 

tests/integrations/mcs/scheduling/server_test.go

@@ -1100,121 +1100,3 @@ func (suite *serverTestSuite) checkConcurrentAllocatedID(re *require.Assertions,
 	})
 	re.Equal(4000, len)
 }
-
-func (suite *serverTestSuite) TestForwardSplitRegion() {
-	re := suite.Require()
-	tc, err := tests.NewTestSchedulingCluster(suite.ctx, 1, suite.cluster)
-	re.NoError(err)
-	defer tc.Destroy()
-	tc.WaitForPrimaryServing(re)
-
-	s := &server.GrpcServer{Server: suite.pdLeader.GetServer()}
-
-	// Create stores
-	for i := uint64(1); i <= 3; i++ {
-		resp, err := s.PutStore(
-			context.Background(), &pdpb.PutStoreRequest{
-				Header: &pdpb.RequestHeader{ClusterId: suite.pdLeader.GetClusterID()},
-				Store: &metapb.Store{
-					Id:      i,
-					Address: fmt.Sprintf("mock://tikv-%d:%d", i, i),
-					State:   metapb.StoreState_Up,
-					Version: "7.0.0",
-				},
-			},
-		)
-		re.NoError(err)
-		re.Empty(resp.GetHeader().GetError())
-	}
-
-	// Create a region via region heartbeat
-	grpcPDClient := testutil.MustNewGrpcClient(re, suite.pdLeader.GetServer().GetAddr())
-	stream, err := grpcPDClient.RegionHeartbeat(suite.ctx)
-	re.NoError(err)
-
-	peers := []*metapb.Peer{
-		{Id: 11, StoreId: 1},
-		{Id: 22, StoreId: 2},
-		{Id: 33, StoreId: 3},
-	}
-
-	regionReq := &pdpb.RegionHeartbeatRequest{
-		Header: testutil.NewRequestHeader(suite.pdLeader.GetClusterID()),
-		Region: &metapb.Region{
-			Id:       100,
-			Peers:    peers,
-			StartKey: []byte(""),
-			EndKey:   []byte(""),
-		},
-		Leader:          peers[0],
-		ApproximateSize: 100 * units.MiB,
-		ApproximateKeys: 1000,
-	}
-	err = stream.Send(regionReq)
-	re.NoError(err)
-
-	// Wait for the region to be created in scheduling cluster
-	testutil.Eventually(re, func() bool {
-		region := tc.GetPrimaryServer().GetCluster().GetRegion(100)
-		return region != nil && region.GetApproximateSize() == 100
-	})
-
-	// Test SplitRegions request
-	splitReq := &pdpb.SplitRegionsRequest{
-		Header: &pdpb.RequestHeader{ClusterId: suite.pdLeader.GetClusterID()},
-		SplitKeys: [][]byte{
-			[]byte("m"), // Split key in the middle
-		},
-		RetryLimit: 3,
-	}
-
-	go func() {
-		// make sure the region heartbeat is sent after the SplitRegions request
-		time.Sleep(time.Second)
-
-		regionReq = &pdpb.RegionHeartbeatRequest{
-			Header: testutil.NewRequestHeader(suite.pdLeader.GetClusterID()),
-			Region: &metapb.Region{
-				Id:    100,
-				Peers: peers,
-				RegionEpoch: &metapb.RegionEpoch{
-					Version: 1,
-				},
-				StartKey: []byte(""),
-				EndKey:   []byte("m"),
-			},
-			Leader:          peers[0],
-			ApproximateSize: 100 * units.MiB,
-			ApproximateKeys: 1000,
-		}
-		err = stream.Send(regionReq)
-		re.NoError(err)
-		regionReq = &pdpb.RegionHeartbeatRequest{
-			Header: testutil.NewRequestHeader(suite.pdLeader.GetClusterID()),
-			Region: &metapb.Region{
-				Id:    101,
-				Peers: peers,
-				RegionEpoch: &metapb.RegionEpoch{
-					Version: 1,
-				},
-				StartKey: []byte("m"),
-				EndKey:   []byte(""),
-			},
-			Leader:          peers[0],
-			ApproximateSize: 100 * units.MiB,
-			ApproximateKeys: 1000,
-		}
-		err = stream.Send(regionReq)
-		re.NoError(err)
-	}()
-
-	// Forward SplitRegions request through PD to scheduling service
-	splitResp, err := grpcPDClient.SplitRegions(suite.ctx, splitReq)
-	re.NoError(err)
-	re.Empty(splitResp.GetHeader().GetError())
-
-	// The response should contain the finished percentage
-	re.Equal(uint64(100), splitResp.GetFinishedPercentage())
-	// Should have regions IDs for the split operation
-	re.Equal([]uint64{101}, splitResp.GetRegionsId())
-}