Skip to content

Conversation

@rleungx
Copy link
Member

@rleungx rleungx commented Jul 3, 2025

What problem does this PR solve?

Issue Number: Close #9482

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Jul 3, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 3, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-03 08:47:54.609812934 +0000 UTC m=+1557527.332991917: ☑️ agreed by lhy1024.
  • 2025-07-03 08:51:25.703017078 +0000 UTC m=+1557738.426196060: ☑️ agreed by bufferflies.

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.21%. Comparing base (b88e47d) to head (64690ef).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9483      +/-   ##
==========================================
+ Coverage   76.20%   76.21%   +0.01%     
==========================================
  Files         481      481              
  Lines       75538    75552      +14     
==========================================
+ Hits        57560    57585      +25     
+ Misses      14405    14379      -26     
- Partials     3573     3588      +15     
Flag Coverage Δ
unittests 76.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit f1b0c68 into tikv:master Jul 3, 2025
44 of 48 checks passed
@rleungx rleungx deleted the fix-resp branch July 4, 2025 01:57
okJiang pushed a commit to okJiang/pd that referenced this pull request Aug 7, 2025
close tikv#9482

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: okjiang <819421878@qq.com>
okJiang added a commit to okJiang/pd that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[next gen on clould] native br restore failed due to scatter failed

3 participants