-
Notifications
You must be signed in to change notification settings - Fork 0
Add UI-based merge conflict resolution #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pedrogaudencio
wants to merge
86
commits into
master
Choose a base branch
from
change-request-conflict-resolution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 67 commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
1113f83
pulls: add conflicts tab to change request menu
pedrogaudencio 862ca41
pulls: add conflicts tab to change request view
pedrogaudencio 5b0eb4f
pulls: create conflicts template for change request view
pedrogaudencio 62e7997
pulls: add locale for tabs
pedrogaudencio ab4f96b
pulls: use base branch commit instead of merge base for change reques…
pedrogaudencio d400b6b
add resolve box/selection for each conflict
pieer e9a8b56
modernize DOM manipulation methods and clean up CSS formatting
pieer 10058dd
fix: insert conflict wrapper in the correct order
pieer 422c21e
fix: explicitly classify unmatched additions and deletions as conflicts
pieer 4309354
fix: add active state styling to conflicts tab
pieer 4770784
fix: use standard diff background variables instead of hardcoded hex …
pieer d4e0980
fix: use proper template cloning and allow toggle for conflict resolu…
pieer 3ef484d
fix: add missing button styles to Keep this button in conflict review
pieer 70427f2
fix: resolve eslint unicorn/prefer-dom-node-append error
pieer bfc1dc9
Merge remote-tracking branch 'origin/master' into change-request-conf…
pieer 3e19006
Fix toast editor styling issue
pieer d59a856
feat: redesign pull request conflict UI with improved resolution flow…
pieer 792d194
feat: implement backend support for resolving pull request merge conf…
pieer 3f42255
refactor: modernize conflict resolution submission using internal POS…
pieer 09ee5a0
refactor: simplify head range boundary calculation using min function…
pieer 31c05a7
feat: implement merge commit creation for conflict resolution with su…
pieer ffda7b7
refactor: remove commit signing status display from pull request merg…
pieer 6610c55
refactor: replace conflict choice selection with manual text resoluti…
pieer 14e53ef
routers: gate SubmitConflictResolution behind auth and merge permission
pedrogaudencio 0e06b53
routers: validate conflict-resolution paths against pull.ConflictedFiles
pedrogaudencio b259684
web_src: send per-file conflict index from conflict-resolution UI
pedrogaudencio c1ed75a
routers: do not flush conflict groups on DiffLineSection
pedrogaudencio 2315ac2
routers: surface unappliable conflict groups instead of silently drop…
pedrogaudencio 3601cbd
locale: route conflicts UI strings through ctx.Locale
pedrogaudencio 024df63
routers: cap conflict-resolution request body via MaxBytesReader
pedrogaudencio 7c4200f
url: fix IPv6-with-zone test case and panic on parse failure
pedrogaudencio d746302
fix #diff-file-boxes gap changed globally instead of scoping to confl…
pieer 87771e4
fix await initToastCommentEditor lacks error handling
pieer 07229a3
fix Mixed indentation in tab_menu.tmpl
pieer 559e050
routers: restrict conflict resolution to the PR creator
pedrogaudencio 1b45a84
routers: let PR creator/admin bypass IsUserAllowedToUpdate for conflicts
pedrogaudencio d98eab2
UI: Restrict conflict resolution button to PR owners and maintainers
pieer 5e073d6
refactor: comment out update_branch_by_merge template calls in pull m…
pieer 3ab403f
feat: localize merge permission description in pull request merge box
pieer 590e04b
refactor: localize diff split header labels and update current articl…
pieer a9a83bb
feat: localize the resolve conflicts button text in pull request merg…
pieer ac09783
refactor: remove unused blob lookups in conflict diff template
pieer 8ca30f6
refactor: consolidate conflict submission button state management int…
pieer 33bb8fb
chore: update phrasing for automated merge description
pieer 83b0025
apply resolutions for chunks where the head side is empty
pieer 13761f5
refactor: improve conflict resolution validation, UI, and file handli…
pieer dcf5351
Merge branch 'master' into change-request-conflict-resolution
pieer 394a846
refactor: update conflict review UI with improved layout, cleaner sty…
pieer f87cd33
feat: update conflict tab icon and add badge for conflicted file count
pieer ad743ef
feat: add active state styling for labels within tabular menu items
pieer bc2bd82
feat: implement responsive layout for conflict diffs and inject side …
pieer f929ba2
style: improve mobile responsive layout for PR and conflict diff views
pieer b91e108
fix: restore update_branch_by_merge template calls in pull merge box
pieer ceec1d8
fix: replace hardcoded hex colors with CSS theme variables in conflic…
pieer 200ca51
fix: reject empty conflicts array in SubmitConflictResolution
pieer 243022b
fix: add void to initConflictReview call to surface promise rejections
pieer 3b36906
fix: correct conflict count label to say 'conflicted file(s)' not 'Co…
pieer 7e3749e
chore: update terminology to change requests in merge permission desc…
pieer 3dae394
fix: correct insertion point for consecutive headless conflict groups
pieer d6fcc4b
fix: add missing trailing newline to conflicts.tmpl
pieer 46ca612
docs: add sync contract comment between buildConflictWrappers and ext…
pieer f9d1103
fix: use HTTP status code instead of statusText in submit error message
pieer 0b017e9
fix: remove per-section flush in extractConflictGroups to match front…
pieer 9de1486
fix: resolve ESLint errors in conflict review and diff modules
pieer de8b767
fix: resolve Go lint errors in pull.go
pieer 6d10fa8
style: update background colors for code diff conflict table cells
pieer cf6f364
fix: replace --color-muted-text with standard --color-text-light-2 in…
pieer 91eedee
fix: remove diff line limit on conflict resolution page
pieer f313e7c
fix: return 409 instead of 500 when head branch updated during confli…
pieer a070b7e
fix: restore submit button text and use toast for conflict resolution…
pieer 318acee
fix: pass WhitespaceBehavior to diff options in conflict resolution h…
pieer 9c70710
fix: hide disabled squash merge button for users without merge permis…
pieer 9a0dd82
fix: guard conflict resolution against stale base commit and concurre…
pieer 595bb06
fix: also check head commit ID for stale conflict resolution submissions
pieer f4b6760
fix: preserve file mode and handle delete conflicts in conflict resol…
pieer d94bc69
fix: show actionable error when a conflicted file is binary or too large
pieer dd2d1ed
style: remove background and border overrides from selected conflict …
pieer 9dfcad5
Merge branch 'master' into change-request-conflict-resolution
pieer bbb7523
pull: use real git merge tree for conflict resolution commit
pedrogaudencio bc1895b
pull: render conflicts from real merge index
pedrogaudencio c48bb77
pull: harden conflict mode and stale checks
pedrogaudencio 822ce58
pull: localize unsupported conflict template
pedrogaudencio 8abaca3
lint: fix issues
pedrogaudencio 6012b0d
lint: remove useless import
pedrogaudencio d946dbf
tests: fix linting
pedrogaudencio 5832fa5
pull: check conflict state before payload files
pedrogaudencio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.