✨ Add mobile-friendly select dropdown for Bootstrap nav-tabs #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace overflowing/wrapped tabs with compact select on small screens - Bidirectional sync between select and Bootstrap tab
krmax44
reviewed
Aug 14, 2025
| }) | ||
|
|
||
| // Reevaluate on content size changes | ||
| if ('ResizeObserver' in window) { |
Member
There was a problem hiding this comment.
We only target browsers with support for ResizeObserver, so we can omit timer-based workarounds.
krmax44
reviewed
Aug 14, 2025
| document.querySelectorAll<HTMLElement>('ul.nav.nav-tabs').forEach(initSelectForNavTabs) | ||
| } | ||
|
|
||
| if (typeof document !== 'undefined') { |
Member
There was a problem hiding this comment.
When would document be undefined? Since we include scripts at the end of body, just calling initAll should be sufficient, as the DOM content has already been loaded.
Member
|
Maybe it makes sense to keep the tab look-and-feel, so that it can be identified as such: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nav.nav-tabson small screens with a compact<select>placed above the tab barGoal